Review queue · ContextStream

Preserve row state when search results reorder

Replace the index-based React key with the result’s stable ID so expanded and selected states stay attached to the correct row.

Ready to review

1 file 1 line changed Focused change

Recalled from Slack Why this fix was made Matched

Search results are re-ranked when streaming completes. Index keys can move expanded state to the wrong row; use the result ID so React preserves the right item.

Slack · #frontend Frontend team · Today, 3:42 PM

Source message
“The stream changes the relevance order after the first render. Let’s stop using the array index as the key or the open row can jump.”

Exact code citation

src/components/SearchResults.tsx +1 −1

                      
                        return (
                    
                          <ul className="results">
                    
                            {results.map((result, index) => (
                    
                      −
                              <ResultRow key={index} result={result} />
                    
                      +
                              <ResultRow key={result.id} result={result} />
                    
                            ))}
                    
                          </ul>
                    
                        );

What should change?